Add ActivationTelemetryService for first-time event tracking#103
Merged
dimitar-radenkov merged 2 commits intoMay 15, 2026
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR introduces an ActivationTelemetryService to centralize “activation” telemetry and add one-time tracking for a user’s first capture/recording, with optional “time from install” dimensions persisted in UserSettings.
Changes:
- Added
ActivationTelemetryService(+ interface) and wired it intoApp.xaml.csfor capture/record completion events. - Extended
UserSettingswithInstallCreatedUtcand “first completion tracked” flags, and updatedUserSettingsService.Clone(...)accordingly. - Added unit tests validating first-time events are emitted only once.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Pointframe/Services/Infrastructure/UserSettingsService.cs | Ensures new UserSettings fields survive Update() by extending Clone(...). |
| Pointframe/Services/Infrastructure/IActivationTelemetryService.cs | Defines the activation telemetry API used by App. |
| Pointframe/Services/Infrastructure/ActivationTelemetryService.cs | Implements capture/record completion telemetry + first-time gating via persisted settings. |
| Pointframe/Models/UserSettings.cs | Adds persisted install timestamp and first-time tracking flags. |
| Pointframe/App.xaml.cs | Registers the new service, routes completion handlers through it, and initializes install metadata. |
| Pointframe.Tests/Services/ActivationTelemetryServiceTests.cs | Covers one-time tracking behavior and duration parsing for recordings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| public bool FirstCaptureCompletedTracked { get; set; } | ||
|
|
||
| public bool FirstRecordingCompletedTracked { get; set; } |
Comment on lines
461
to
465
|
|
||
| if (_userSettings.Current.InstallCreatedUtc is null) | ||
| { | ||
| _userSettings.Update(s => s.InstallCreatedUtc = DateTime.UtcNow); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.