Fix CI data race in host connect retry tests - #306
Merged
Conversation
Remove t.Parallel from tests that mutate global config.AppConfig. CI runs go test -race, and the parallel AppConfig writes raced with NewPool/NewClientManager reads in the sibling test. Co-authored-by: Dominic Letz <dominicletz@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes t.Parallel() from TestHostConnectRetryBackoff and TestDoSelectNextHostSkipsBackoff in rpc/client_manager_retry_test.go because these tests mutate the global config.AppConfig configuration, which could lead to race conditions if run in parallel. Explanatory comments have been added to document this behavior. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Master CI failed on commit
033d081("Implement backoff for dead servers") becausego test -racedetected a data race in the new retry tests.Failed run: Ubuntu job failed during
make openssl/make test; other platform jobs were cancelled as a result.Root cause
TestHostConnectRetryBackoffandTestDoSelectNextHostSkipsBackoffboth callt.Parallel()while writingconfig.AppConfig.NewClientManager→NewPoolreads that global, so the two tests race under-race.Fix
Remove
t.Parallel()from both tests, matchingclient_manager_getdefault_test.goand AGENTS.md guidance to uset.Parallel()only when truly safe.Verification
Passes locally after this change.