Fix eth_getStorageAt batch QUANTITY encoding for Base RPC - #20
Merged
Conversation
get_storage_many bypassed normalize_args and encoded blocks like 0x02f1cf00, which Base RPC rejects as -32602 invalid params and crashed EdgeV2 connections. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
CI was red on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_storage_manywas sending padded block hex (e.g.0x02f1cf00) viabatch_call, which bypassesrpc/3/normalize_args.-32602 invalid params, raising in EdgeV2 and dropping the connection.normalize_argsso blocks use short JSON-RPC QUANTITY encoding (0x2f1cf00).Test plan
DIODE_MINIMAL_TEST=1 mix test --no-start test/remote_chain/rpc_cache_test.exsgetaccountvalues/ storage reads no longer crash EdgeV2 with-32602Made with Cursor