Correctly parse file lines which include negative durations#2
Open
sethhochberg wants to merge 1 commit intodirble:masterfrom
Open
Correctly parse file lines which include negative durations#2sethhochberg wants to merge 1 commit intodirble:masterfrom
sethhochberg wants to merge 1 commit intodirble:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many implementations of M3U and PLS will consider a negative length to be "unknown" or "ignore" - this is particularly common with internet streams, but is occasionally seen with actual files, too. The current regex match here will fail when attempting to parse file lines with these negative durations.
http://forums.winamp.com/showthread.php?threadid=65772
This PR fixes the regex to detect negative durations when present, and parse them correctly.