Add automatic shutdown mechanism for safer remote mitm6 usage#46
Open
quahac wants to merge 2 commits intodirkjanm:masterfrom
Open
Add automatic shutdown mechanism for safer remote mitm6 usage#46quahac wants to merge 2 commits intodirkjanm:masterfrom
quahac wants to merge 2 commits intodirkjanm:masterfrom
Conversation
Introduced a safety mechanism that automatically stops mitm6 after 15 minutes when no DNS domain filters are provided. This prevents unintended broad network impact during default runs. The auto-shutdown is disabled if a custom --timer value is specified, allowing controlled long-running sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an automatic shutdown mechanism for safer use of mitm6, especially in remote or unattended environments.
New functionality:
If no DNS domain filter is provided using --domain, mitm6 will automatically shut down after 15 minutes to prevent unintended impact on the entire network.
A new --timer parameter has been added to configure a custom shutdown time (in minutes), which overrides the default 15-minute timer.
This change adds a safety layer for scenarios where mitm6 may be left running remotely or forgotten, reducing accidental broad network impact.