Improve Storefront: add change listener and richer storefront data - #5
Merged
Conversation
pass currency when fetching storefront if it's available
charleschen
marked this pull request as ready for review
March 4, 2026 18:35
charleschen
commented
Mar 4, 2026
| const paymentProvider = props?.paymentProvider ?? 'Play Store'; | ||
| if (!hasPaymentProviderProperValue(paymentProvider)) { | ||
| config_plugins_2.WarningAggregator.addWarningAndroid('react-native-iap', `The payment provider '${paymentProvider}' is not supported. Please update your app.json file with one of the following supported values: 'Play Store', 'Amazon AppStore', or 'both'.`); | ||
| config_plugins_1.WarningAggregator.addWarningAndroid('react-native-iap', `The payment provider '${paymentProvider}' is not supported. Please update your app.json file with one of the following supported values: 'Play Store', 'Amazon AppStore', or 'both'.`); |
Author
There was a problem hiding this comment.
oh i did not notice this change. i think this is from claude code. i need to see what this is doing
Author
There was a problem hiding this comment.
oh it's not claude, it's an auto generated file
tjmabey
reviewed
Mar 9, 2026
tjmabey
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority P1
What
Storefront.updateslistener that emits"storefront-updated"events when the user's App Store storefront changesgetStorefrontto return a serialized object ({ countryCode, currency }) instead of just a country code stringWhy
currencyis only available for iOS 17.0+, so in our client code we still need to handle if it's missing. I think it's still worth while to pass currency so that if there were currency change for a country (without us being aware), the impact is much smaller.Tests
Task