DEV: Warn when top-level config keys are unrecognized#37
Closed
ducks wants to merge 1 commit into
Closed
Conversation
Previously, any top-level key not consumed by pups or the discourse_docker launcher was silently ignored. This made typos and misplaced keys invisible. A hook stanza at the wrong indent level, or 'befor_code' with a typo, would parse cleanly and produce nothing. Log a warning at boot time for any top-level key that's outside the known set. Behavior is unchanged: unknown keys are still ignored, just no longer silently. Keys explicitly passed in the 'ignored' argument don't trigger the warning, since the caller has signaled intent.
Member
|
this is weird though, this is not a pups responsibility, instead it should accept a schema and warn on that ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any top-level key not consumed by pups or the discourse_docker launcher was silently ignored. This made typos and misplaced keys invisible. A hook stanza at the wrong indent level, or 'befor_code' with a typo, would parse cleanly and produce nothing.
Log a warning at boot time for any top-level key that's outside the known set. Behavior is unchanged: unknown keys are still ignored, just no longer silently.
Keys explicitly passed in the 'ignored' argument don't trigger the warning, since the caller has signaled intent.