CI/packaging cleanup: pages.yml allowlist + x-maintenance-intent - #5
Merged
Conversation
The GitHub Pages workflow referenced actions that are not on the repository's curated Actions allowlist (and stale checkout/setup-ocaml versions), so it failed at startup once Actions was enabled. + pin actions/configure-pages to v6.0.0 (SHA) + pin actions/upload-pages-artifact to v5.0.0 (SHA) + pin actions/deploy-pages to v5.0.0 (SHA) + bump actions/checkout to the allowlisted @v6 + pin ocaml/setup-ocaml to the allowlisted v3 SHA Signed-off-by: Jonah Beckford <9566106-jonahbeckford@users.noreply.gitlab.com>
The opam maintenance-intent placeholder for "the newest version" is `(latest)` (parenthesized), matching the form already published for dkml-c-probe.3.2.0 in opam-repository. The bare `latest` was a literal version string rather than the placeholder. Signed-off-by: Jonah Beckford <9566106-jonahbeckford@users.noreply.gitlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-ups after the 4.0.0 release.
pages.yml— fit the Actions allowlistThe GitHub Pages (odoc) workflow startup-failed once Actions was enabled,
because its actions aren't on the repository's curated allowlist. Pinned
them to SHA and bumped the stale
checkout/setup-ocaml.Requires three new allowlist entries (Settings > Actions > General;
SHA-pinned per repo convention) before it can run green on
main:(
pages.ymltriggers only on push tomain, so it does not run on this PR.)x-maintenance-intent— use the(latest)placeholderThe source template used the bare
latestrather than the(latest)placeholder that opam expects (and that the published
dkml-c-probe.3.2.0already uses). Regenerated
dkml-c-probe.opamaccordingly.