fix(pi-pi): truncate widget message to terminal width#20
Open
dwainm wants to merge 1 commit intodisler:mainfrom
Open
fix(pi-pi): truncate widget message to terminal width#20dwainm wants to merge 1 commit intodisler:mainfrom
dwainm wants to merge 1 commit intodisler:mainfrom
Conversation
Prevents TUI crash when terminal width < message length. The 'No experts found' message was exceeding terminal bounds causing 'Rendered line exceeds terminal width' error. Fixes: truncateToWidth(theme.fg(...), width, '')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 'No experts found' message in the pi-pi widget render was causing a TUI crash on narrow terminals:
This occurred when the terminal width was less than the message length.
Solution
Wrap the message with
truncateToWidth()to ensure it fits within the available width:Testing