Skip to content

Update advertised protocol version to 16 #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgeoghegan merged 3 commits into from
Feb 27, 2026
Merged

Update advertised protocol version to 16 #4403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f14c315
Update advertised protocol version to 16
tgeoghegan Feb 26, 2026
6d68ffa
update domain separation tags, too
tgeoghegan Feb 27, 2026
9516083
fix test
tgeoghegan Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aggregator_api/src/routes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ pub(super) async fn get_config(
LazyLock::new(|| format!("{}-{}", env!("CARGO_PKG_VERSION"), git_revision()));

Json(AggregatorApiConfig {
protocol: "DAP-09",
protocol: "DAP-16",
dap_url: config.public_dap_url.clone(),
role: AggregatorRole::Either,
vdafs: Vec::from([
Expand Down
2 changes: 1 addition & 1 deletion aggregator_api/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ async fn get_config() {
assert_body_contains!(
conn,
concat!(
r#""protocol":"DAP-09","dap_url":"https://dap.url/","role":"Either","vdafs":"#,
r#""protocol":"DAP-16","dap_url":"https://dap.url/","role":"Either","vdafs":"#,
r#"["Prio3Count","Prio3Sum","Prio3Histogram","Prio3SumVec"],"#,
r#""batch_modes":["TimeInterval","LeaderSelected"],"#,
r#""features":["TokenHash","UploadMetrics","TimeBucketedLeaderSelected","#,
Expand Down
2 changes: 1 addition & 1 deletion core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ pub mod taskprov {

/// This value is used in a few places throughout the protocol to identify the draft of DAP being
/// implemented.
const DAP_VERSION_IDENTIFIER: &str = "dap-15";
const DAP_VERSION_IDENTIFIER: &str = "dap-16";

/// Returns the given [`Url`], possibly modified to end with a slash.
///
Expand Down
Loading