-
Notifications
You must be signed in to change notification settings - Fork 44
Fixes issues #108 and #124. #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| Adam Fineman <afineman@etagc.com> | ||
| Di Xu <dixudx@users.noreply.github.com> | ||
| Felipe Ruhland <felipe.ruhland@gmail.com> | ||
| stephenhsu <stephenhsu90@gmail.com> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,11 @@ class RTCClient(RTCBase): | |
| the url ends with 'jazz', otherwise to `False` if with 'ccm' | ||
| (Refer to issue #68 for details) | ||
| :type ends_with_jazz: bool | ||
| :param attribute_map: (optional) Dictionary mapping RTC attributes to | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually I don't get what this If you want to know all the alias, you can refer to
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hello. Just following up. Is there anything else I can do to move this along?
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can |
||
| keys. If ommitted, the default mapping will be, for example, | ||
| {'ns:some-attr': 'some_attr', 'other_ns:otherattr': 'otherattr', ...} | ||
| Also, long attributes with dots in their names will be discarded | ||
| unless present in the `attribute_map`. | ||
|
|
||
| Tips: You can also customize your preferred properties to be returned | ||
| by specified `returned_properties` when the called methods have | ||
|
|
@@ -47,7 +52,7 @@ class RTCClient(RTCBase): | |
| log = logging.getLogger("client.RTCClient") | ||
|
|
||
| def __init__(self, url, username, password, proxies=None, searchpath=None, | ||
| ends_with_jazz=True): | ||
| ends_with_jazz=True, attribute_map=None): | ||
| """Initialization | ||
|
|
||
| See params above | ||
|
|
@@ -56,6 +61,7 @@ def __init__(self, url, username, password, proxies=None, searchpath=None, | |
| self.username = username | ||
| self.password = password | ||
| self.proxies = proxies | ||
| self.attribute_map = attribute_map | ||
| RTCBase.__init__(self, url) | ||
|
|
||
| if not isinstance(ends_with_jazz, bool): | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.