Open
Conversation
Currently only implements generating the recipient's shareable payment code.
stepansnigirev
requested changes
Aug 14, 2022
Refactored blind/unblind to eliminate redundant code.
stepansnigirev
requested changes
Aug 27, 2022
Contributor
stepansnigirev
left a comment
stepansnigirev
left a comment
There was a problem hiding this comment.
Overall, looks good. A few small changes required (i.e. your test doesn't pass). Also not clear if TODO will be addressed in this PR or in a separate one.
Note: regtest blind/unblind still has a bug I'm trying to work through. But as far as I can tell, mainnet works as expected, as confirmed via the test cases.
Contributor
Author
|
After my most recent commit, I am now satisfied with where this PR is at. Awaiting further review/feedback, but otherwise I consider this PR complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements:
Implementation matches Samourai (still to be confirmed) and Sparrow (tested).