Open
Conversation
Member
priyapahwa
commented
Feb 12, 2024
- Add space between Software Foundation
- Underline links for DSF & registered trademark
- Add space between Software Foundation - Underline links for DSF & registered trademark Signed-off-by: Priya Pahwa <pahwa.priya19@gmail.com>
Member
|
Hi and thanks for the pull request! I'm impressed you spotted the missing space in the footer, I didn't know anyone actually read that 😅 For the underlining, I would prefer to do it in CSS instead of using
Do you have an opinion on what would be the better option of the two? Or maybe a third idea? Thanks! ✨ |
Member
Author
|
Hey @bmispelon, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.