Open
Conversation
djcb
reviewed
Feb 4, 2024
Owner
|
Ah, thanks, that's much less intrusive! Did you test on Linux as well? |
Author
|
@djcb I have addressed your comment as well as added a section in README explaining how to make it work on Windows. I cannot test on Linux as I do not have a Linux machine. FWIW, I was able to test it on a Mac, which should be close enough. Let me know if any more changes are needed. |
Author
|
I should note that I have tested the changes by modifying the existing installation. I could not compile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm back with another approach to make
mu4eon windows work withmuin WSL. I was playing withmu4ewith the intention to define an advice aroundmu4e--server-call-muto translate whatever paths are being returned frommu. However, I discovered a really useful behavior ofinsert-file-contentson windows, making it unnecessary to transform any paths. My interaction on Emacs mailing list is here. I'm reproducing the email here as the email text will explain it better.Basically, if you start
mu4efrom any buffer within//wsl.localhost/Ubuntu/...,insert-file-contentswill prepend the drive letter, in this case//wsl.localhost/Ubuntu/to all paths, pointing it to the right file. The whole thing works transparently as far as mu4e is concerned.Then why am I relaxing the validations?
muis not a windows native program. It is available in WSL. Hence(file-executable-p mu4e-mu-binary)will always return false. Moreover, we need to startmuin WSL, which can be done by settingand running
muas a shell command instead of a windows native process. Is there a way to incorporate these changes inmu4e? We can then maybe explain in the README how one can get this setup working on Windows.