You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, just found 2 places that annoyed me under dark mode, therefore I made some fixes.
Remove the default style from browsers under dark mode
I found the color-scheme: dark/light on the HTML element will apply the default style from browsers.
As the image shows below, you can see a darker gray background behind the form region, comparing the lighter gray background of the user's site.
Fix the text color of the submit button
After removing the color-scheme: dark/light style on the HTML element, the text color of the submit button will still be white under dark mode. So I added a new class dark:text-gray-100 on the button to correct the text color.
Hi, just found 2 places that annoyed me under dark mode, therefore I made some fixes.
Remove the default style from browsers under dark mode
I found the color-scheme: dark/light on the HTML element will apply the default style from browsers.
As the image shows below, you can see a darker gray background behind the form region, comparing the lighter gray background of the user's site.
Fix the text color of the submit button
After removing the color-scheme: dark/light style on the HTML element, the text color of the submit button will still be white under dark mode. So I added a new class dark:text-gray-100 on the button to correct the text color.
Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, just found 2 places that annoyed me under dark mode, therefore I made some fixes.
Remove the default style from browsers under dark mode
I found the
color-scheme: dark/lighton the HTML element will apply the default style from browsers.As the image shows below, you can see a darker gray background behind the form region, comparing the lighter gray background of the user's site.
Fix the text color of the submit button
After removing the
color-scheme: dark/lightstyle on the HTML element, the text color of the submit button will still be white under dark mode. So I added a new classdark:text-gray-100on the button to correct the text color.