[Build dll] Fix errors and added steps in docs#21
Open
mfdeveloper wants to merge 1 commit intodkager:masterfrom
Open
[Build dll] Fix errors and added steps in docs#21mfdeveloper wants to merge 1 commit intodkager:masterfrom
mfdeveloper wants to merge 1 commit intodkager:masterfrom
Conversation
bear101
reviewed
Feb 20, 2022
| hasBraille(braille) | ||
| {} | ||
| ScreenReaderDriver& operator=(const ScreenReaderDriver&) {} | ||
| ScreenReaderDriver& operator=(const ScreenReaderDriver&); |
There was a problem hiding this comment.
Doesn't this cause a linker error?
I think what you want to do is this:
ScreenReaderDriver& operator=(const ScreenReaderDriver&) = delete;
to prevent copying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I found some problems to build the main
C++.dll to use with the wrappers (in my case, on .net). This PR contains some fixes to avoid the compiling errors.Also, I added a step by step guide in
docs/README.mdto describe which dependencies you should install first, and how generate the .dll.Besides that, I would like to suggest:
CMaketo compile the C++ dll as a alternative to usenmakeorjomwith `Makefile's. That will be more easy to upgrade this project to a "cross platform" approach in the future 😄