Open
Conversation
Tolk can now be built with Meson. The Meson build system builds Tolk.dll, TolkDotNet.dll, and Tolk.jar, and is instructed on how to distribute tolk.py, and build and distribute README.html. Meson feature options are used to determine which bindings are built and distributed. By default, they're set to auto, so bindings will automatically be built if the corrisponding language compilers / runtimes are found. There is also a feature option for docs, which will build the documentation if Pandoc is found when set to auto. There is also a boolean feature that determines whether JNI support is enabled. If building Java bindings, this will be forced on. This makes it significantly easier to use Tolk from Meson projects as a subproject. It also means Tolk benefits from Meson's existing features and compiler / language support and integration, so theoretically one could more easily build Tolk with MinGW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Meson build system support for Tolk. The Meson build system builds
Tolk.dll, TolkDotNet.dll, and Tolk.jar, and is instructed on how to
distribute tolk.py, and build and distribute README.html.
I've added the following build-time-configurable Meson options:
-Djni=trueBy default, they're set to auto, so bindings will
automatically be built if the corresponding language compilers /
runtimes are found. When building Java bindings,
jniis force-enabled.This makes it significantly easier to use Tolk from Meson projects as a subproject. It also means Tolk benefits from Meson's existing features and compiler / language support and integration, so theoretically one could more easily build Tolk with MinGW in the future.
Using Meson may also pave the way for #5. I know @dkager said in that thread that cross-platform Tolk won't be happening, as their is only 1 viable screen reader for most of the other platforms, but a cross-platform TTS library is sorely needed for applications such as audio games, and besides, on Linux at least, I'm one of the creaters of the Odilia Screen Reader, so there are now multiple Linux screen readers that Tolk could implement support for.
Either way, having a proper build system makes this project easier to build and use in other projects. It is even possible to generate a CMake package file using Meson, though I haven't yet done this.