Skip to content

Update README.md#29

Open
mikelibg wants to merge 2 commits into
dkapur17:masterfrom
mikelibg:master
Open

Update README.md#29
mikelibg wants to merge 2 commits into
dkapur17:masterfrom
mikelibg:master

Conversation

@mikelibg
Copy link
Copy Markdown

Fixing readme example code for the developers to be able to run the example.
Fixes:

  1. missing import to the streamlit package
  2. wrong streamlit state name usage
  3. wrong node/edge definition
  4. wrong parameter name key instead id

Fixing readme example code for the developers to be able to run the example
@dkapur17
Copy link
Copy Markdown
Owner

dkapur17 commented Nov 4, 2024

Hi @mikelibg. Thanks for the PR! The changes look great, except for the addition of the statement importing Streamlit in the first two code blocks, since the script actually wouldn't need that import to run. Adding the statement might give others a sense that it NEEDS to be imported, so I chose to omit it. If you go ahead and make this change, I'll merge the PR.

removed unneeded streamlit import
@mikelibg
Copy link
Copy Markdown
Author

  • You are right. Removed the unneeded import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants