Skip to content

Removed file unused #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkoster95 merged 12 commits into from
Aug 23, 2025
Merged

Removed file unused #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e012085
Removed file unused
dkoster95 Aug 23, 2025
8163399
updated package
dkoster95 Aug 23, 2025
11a5a84
configuring pipeline
dkoster95 Aug 23, 2025
31f1653
fixed yaml file
dkoster95 Aug 23, 2025
0bb7fe0
check directories
dkoster95 Aug 23, 2025
f53fb35
revert changes
dkoster95 Aug 23, 2025
d750808
configuire swiftlint
dkoster95 Aug 23, 2025
0a934a5
fix linting
dkoster95 Aug 23, 2025
567c79b
remove version check
dkoster95 Aug 23, 2025
c051fca
set swift version
dkoster95 Aug 23, 2025
90fa696
deleted message
dkoster95 Aug 23, 2025
112cf4a
Logger back
dkoster95 Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/swift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: swift-actions/setup-swift@v2
with:
swift-version: "6.1"
- name: Install SwiftLint
run: brew install swiftlint
- name: Check Linting
run: swiftlint
- name: Build
run: swift build -v
- name: Run tests
Expand Down
36 changes: 0 additions & 36 deletions Sources/Network Settings/HostSettingsReader.swift
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions Tests/TestCases/CertificatePinning/URLSessionPinningDelegateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,23 @@ struct URLSessionPinningDelegateTests {
}

private struct TestCases {
static let whenChallengeIsNilExpectInvalidResults = TestMetadata(challenge: Stubs.CertificatePinner.fakeChallenge(with: nil),
static let whenChallengeIsNilExpectInvalid = TestMetadata(challenge: Stubs.CertificatePinner.fakeChallenge(with: nil),
certificatePinnerIsServerTrustedResult: false,
credentialResult: nil,
result: .cancelAuthenticationChallenge)
static let whenChallengeIsValidAndServerIsNotTrustedExpectInvalidResults = TestMetadata(challenge: Stubs.CertificatePinner.fakeChallenge(with: Stubs.CertificatePinner.certificate),
static let whenChallengeIsValidAndServerIsNotTrustedExpectInvalid = TestMetadata(challenge: Stubs.CertificatePinner.fakeChallenge(with: Stubs.CertificatePinner.certificate),
certificatePinnerIsServerTrustedResult: false,
credentialResult: nil,
result: .cancelAuthenticationChallenge)
static let whenChallengeIsValidAndServerIsTrustedExpectValidResults = TestMetadata(challenge: Stubs.CertificatePinner.fakeChallenge(with: Stubs.CertificatePinner.certificate),
static let whenChallengeIsValidAndServerIsTrustedExpectValid = TestMetadata(challenge: Stubs.CertificatePinner.fakeChallenge(with: Stubs.CertificatePinner.certificate),
certificatePinnerIsServerTrustedResult: true,
credentialResult: URLCredential(trust: Stubs.CertificatePinner.fakeChallenge(with: Stubs.CertificatePinner.certificate).protectionSpace.serverTrust!),
result: .useCredential)
}

@Test(arguments: [TestCases.whenChallengeIsNilExpectInvalidResults,
TestCases.whenChallengeIsValidAndServerIsNotTrustedExpectInvalidResults,
TestCases.whenChallengeIsValidAndServerIsTrustedExpectValidResults])
@Test(arguments: [TestCases.whenChallengeIsNilExpectInvalid,
TestCases.whenChallengeIsValidAndServerIsNotTrustedExpectInvalid,
TestCases.whenChallengeIsValidAndServerIsTrustedExpectValid])
func urlSessionTests(metadata: TestMetadata) async {
await confirmation("") { confirmation in
let (sut, mock) = sut()
Expand Down
Loading