fix: remove release tag identity dependency - #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Release run 31574012762 reached publication but failed because
git tag -arequires a tagger identity that a fresh GitHub Actions runner does not have. Hope only requires an immutable version tag that points to the released source, so an annotated tag added an unnecessary dependency.Impact
The release workflow can publish and recover version
2.1.1without configuring Git author metadata. The plugin package is unchanged.Release decision
none— this changes release automation, not the public plugin package.Verification
node --test test/release-tools.test.mjs— 9 passednpm run check— 193 passed; release impactnone 2.1.1 -> 2.1.1