Merged
Conversation
6dea9b6 to
fb0a20b
Compare
LightBender
approved these changes
Mar 1, 2025
Contributor
|
I don't understand how this is passing. https://github.com/dlang-community/D-Scanner/blob/master/src/dscanner/analysis/mismatched_args.d#L56 Offending PR: dlang-community/DCD#763 |
Contributor
|
Oh I see, DCD wasn't updated. https://github.com/dlang-community/D-Scanner/blob/master/dub.selections.json#L4 |
|
Are we waiting on anything to merge this? |
Contributor
|
Apart from the fact that if we did merge it, people who are not me are going to complain about it being broken? Clone it, run dub upgrade on it, and try to build it. Just watch. |
|
DCD has already been updated upstream, so we should be good to go here once we upgrade the submodule and |
|
What's the status of this? can we merge it. This is now holding up PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for interpolated strings