Skip to content

Fix Issue #23356 - ImportC: The preprocessor is improperly invoked, on macOS, when cross-compiling. #23357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
just-harry wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

Fix Issue #23356 - ImportC: The preprocessor is improperly invoked, on macOS, when cross-compiling. #23357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dmd/link.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,7 +1196,7 @@ public int runPreprocessor(Loc loc, const(char)[] cpp, const(char)[] filename, c
// need to redefine some macros in importc.h
argv.push("-Wno-builtin-macro-redefined");

if (target.os == Target.OS.OSX)
version (OSX)
{
argv.push("-fno-blocks"); // disable clang blocks extension
argv.push("-E"); // run preprocessor only for clang
Expand Down
14 changes: 14 additions & 0 deletions compiler/test/compilable/test23356.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// DISABLED: win linux freebsd openbsd netbsd dragonflybsd hurd
// REQUIRED_ARGS: -os=linux
// If clang is invoked improperly as a preprocessor,
// then this will fail to compile and link due to `__check` being undefined.
// If clang is invoked properly as a preprocessor then this will succeed
// as clang won't attempt to compile nor link the file.

// https://github.com/dlang/dmd/issues/23356

int main(void)
{
__check(1);
return 0;
}
Loading