Fix #19514 - stop recursive __traits(compiles) mixin expansion#23360
Open
0-v-0 wants to merge 1 commit into
Open
Fix #19514 - stop recursive __traits(compiles) mixin expansion#233600-v-0 wants to merge 1 commit into
0-v-0 wants to merge 1 commit into
Conversation
dkorpel
requested changes
Jul 4, 2026
dkorpel
left a comment
dkorpel
left a comment
Contributor
There was a problem hiding this comment.
Is this AI generated? This fix makes no sense.
Contributor
Author
|
You're right that I used AI assistance for this fix. I only did an incremental test because the full test crashes with access violation on Windows-MSVC. And it's probably caused by printf format. I'm waiting for PR #23351 to continue. |
Contributor
|
Do you understand the issue and this PR's code change yourself? I don't know what model you use, but it doesn't seem capable of tackling this issue at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.