osthread: suspend() and resume() code deduplication#23361
Open
denizzzka wants to merge 8 commits into
Open
Conversation
2634c78 to
4b9d13b
Compare
b629454 to
805d08f
Compare
denizzzka
commented
Jul 4, 2026
|
|
||
|
|
||
| // Returns true on success | ||
| // TODO: move to posix_impl module |
Contributor
Author
There was a problem hiding this comment.
At the moment it is difficult to do this: it clings to other symbols that have not yet been transferred to posix_impl
0f1d209 to
776b6d4
Compare
Contributor
Author
|
@QuantumSegfault This PR touches WASI implementation |
QuantumSegfault
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got rid of the repeating blocks:
System-related code moved to appropriate dedicated modules in last two commits: for review you can look except these comments - PR becomes clean and understandableI removed these commits: a separate PR transfer will be done for moving
What is happening is part of the process of separating code from different platforms into different modules