fix missing commit and batch cap for silence in testsrc#427
fix missing commit and batch cap for silence in testsrc#427vt-tv merged 2 commits intodmf-mxl:mainfrom
Conversation
|
@aguo-RV could you create a bug report and link it to this PR? I'll merge this one it is linked to an issue. |
|
@KimonHoffmann do you have a few minutes to review this? |
KimonHoffmann
left a comment
KimonHoffmann
left a comment
There was a problem hiding this comment.
Looks great, thanks for the contribution!
Just one small remark regarding the use of memset.
Could you please fix up the original commit and take the opportunity to rebase on the current main?
tools/mxl-gst/testsrc.cpp
Outdated
| if (fragment.size != 0) | ||
| { | ||
| auto const dst = static_cast<std::uint8_t*>(fragment.pointer) + (chan * payloadBuffersSlices.stride); | ||
| ::memset(dst, 0, fragment.size); // fill with silence |
There was a problem hiding this comment.
Maybe use std::memset here?
Regardless of that memset needs cstring to be included. Could you please add this?
aguo-RV
force-pushed
the
bugfix/fix-testsrc-silence-commit
branch
2 times, most recently
from
b5d0da0 to
dc6bbe2
Compare
|
@aguo-RV The latest commit is missing the --signoff. you need to amend the commit and force-push in the branch. |
Signed-off-by: Andrew Guo <andrew.guo@rossvideo.com>
Signed-off-by: Andrew Guo <andrew.guo@rossvideo.com>
aguo-RV
force-pushed
the
bugfix/fix-testsrc-silence-commit
branch
from
dc6bbe2 to
3878fc3
Compare
Done, sorry about that |
KimonHoffmann
left a comment
KimonHoffmann
left a comment
There was a problem hiding this comment.
Thank you for taking care of the requested change.
Looks good to me!
vt-tv
added
the
backport/v1.0
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/v1.0
git worktree add -d .worktree/backport/427/-/release/v1.0 origin/release/v1.0
cd .worktree/backport/427/-/release/v1.0
git switch --create backport/427/-/release/v1.0
git cherry-pick -x d019deff4e0766fb8de17e33846a2022bdac4665 b6a937455adad008b83e3536f4aab8a37cc1e991 |
4 participants
Resolves 449
The silence-filling path in
testsrc.cppis missing the commit samples call.It also doesn't use an audio batch cap like the one found in
looping_filesrc.cpp.