Pickle.dumps does not guarantee ASCII#10
Open
atkinson wants to merge 3 commits intodmgctrl:masterfrom
Open
Conversation
…aranteed to be ASCII, (contradictory to the official docs). Encoding to base64 is necessary in case there are other non-ASCII encodings embedded in the object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was falling in a mess on Postgres when the object being pickled contained encodings other than ASCII.
There's a discrepancy between the docs and reality which you can read about here: http://bugs.python.org/issue2980
I worked around by encoding to base64 before storing the picked object in the db, and then base64 decode on the way out.
Also elected to use the best available decoder seeing as there is no benefit to using the ASCII one (which doesn't guarantee ASCII).