Use filename completion after first argument#5
Open
ericsong wants to merge 3 commits intodmohs:masterfrom
Open
Use filename completion after first argument#5ericsong wants to merge 3 commits intodmohs:masterfrom
ericsong wants to merge 3 commits intodmohs:masterfrom
Conversation
added 3 commits
February 13, 2020 14:57
…w autocompletion from any directory
Owner
|
I don't think a generic solution is appropriate for this. While this works for a common case, one would expect to want to use this framework in a command group scenario, where filename completion would only be appropriate two or three levels in and would otherwise be confusing. My preferred approach is to give the script writer control over where filename completion happens by making it an explicit option during definition, then providing the list by-hand as you've done here (via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing - #4 (comment)