Skip to content

Use filename completion after first argument#5

Open
ericsong wants to merge 3 commits intodmohs:masterfrom
ericsong:master
Open

Use filename completion after first argument#5
ericsong wants to merge 3 commits intodmohs:masterfrom
ericsong:master

Conversation

@ericsong
Copy link
Copy Markdown
Contributor

@ericsong ericsong commented Feb 13, 2020

Addressing - #4 (comment)

@dmohs
Copy link
Copy Markdown
Owner

dmohs commented Apr 12, 2020

I don't think a generic solution is appropriate for this. While this works for a common case, one would expect to want to use this framework in a command group scenario, where filename completion would only be appropriate two or three levels in and would otherwise be confusing.

My preferred approach is to give the script writer control over where filename completion happens by making it an explicit option during definition, then providing the list by-hand as you've done here (via ls).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants