Skip to content

✅ Use createStub for expectation-less doubles + add CLAUDE.md #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schmunk42 merged 2 commits into from
Jun 14, 2026
Merged

✅ Use createStub for expectation-less doubles + add CLAUDE.md #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7b360
:white_check_mark: test: use createStub for doubles without expectations
schmunk42 Jun 14, 2026
9a7ecbf
:memo: docs: add CLAUDE.md (English-only policy)
schmunk42 Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!-- file generated with AI assistance: Claude Code - 2026-06-14 -->

# CLAUDE.md

This is a public open-source package maintained under github.com/dmstr.

## Language policy

**Everything in this repository is in English** — commit messages, code,
comments, and documentation. Do not write German here, even though related
company/customer projects (e.g. the consuming application) use German. These
packages are public and English-only.

## Testing

PHPUnit (^12). Run locally with the bundled CLI-only Docker Compose
(no host PHP required):

docker compose run --rm php

This installs dependencies and runs `vendor/bin/phpunit`. The same runs in CI
via `.github/workflows/tests.yml`.

## Requirements

PHP >= 8.4.
4 changes: 2 additions & 2 deletions tests/Authentication/OAuth2AuthenticationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function testInvalidGrantMarksRequiresReauth(): void

public function testRequiresReauthReadsFromStorage(): void
{
$storage = $this->createMock(TokenStorageInterface::class);
$storage = $this->createStub(TokenStorageInterface::class);
$storage->method('loadTokens')->willReturn([
'access_token' => null,
'refresh_token' => null,
Expand All @@ -97,7 +97,7 @@ public function testRequiresReauthReadsFromStorage(): void

public function testRequiresReauthSurfacesAsInvalidGrantOnDecorate(): void
{
$storage = $this->createMock(TokenStorageInterface::class);
$storage = $this->createStub(TokenStorageInterface::class);
$storage->method('loadTokens')->willReturn([
'access_token' => null,
'refresh_token' => 'r',
Expand Down
9 changes: 6 additions & 3 deletions tests/Client/Bc4ClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ public function testReactiveRefreshOn401ThenRetrySucceeds(): void
new MockResponse('[]', ['http_code' => 200]),
]);

$auth = $this->makeAuthStub('access-1');
// Real mock here (not makeAuthStub): we assert refresh() is called once.
$auth = $this->createMock(AuthenticationInterface::class);
$auth->method('requiresReauth')->willReturn(false);
$auth->method('decorate')->willReturnArgument(0);
$auth->expects($this->once())->method('refresh');

$client = $this->makeClient($http, $auth);
Expand Down Expand Up @@ -110,7 +113,7 @@ public function testRequiresReauthShortCircuits(): void
new MockResponse('SHOULD_NOT_BE_CALLED', ['http_code' => 200]),
]);

$auth = $this->createMock(AuthenticationInterface::class);
$auth = $this->createStub(AuthenticationInterface::class);
$auth->method('requiresReauth')->willReturn(true);

$client = $this->makeClient($http, $auth);
Expand Down Expand Up @@ -165,7 +168,7 @@ private function makeClient(MockHttpClient $http, AuthenticationInterface $auth)

private function makeAuthStub(string $accessToken = 'access-1'): AuthenticationInterface
{
$auth = $this->createMock(AuthenticationInterface::class);
$auth = $this->createStub(AuthenticationInterface::class);
$auth->method('requiresReauth')->willReturn(false);
// Pass the client through unchanged so MockHttpClient::getRequestsCount()
// reflects the actual call sequence. Header injection is exercised in
Expand Down
Loading