Skip to content

Always log uncaught exceptions as level ERROR #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmulter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always log uncaught exceptions as level ERROR #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions chalice/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,12 +668,12 @@ def _get_view_function_response(self, view_function, function_args):
status_code=e.STATUS_CODE)
except Exception as e:
headers = {}
self.log.error("Caught exception for %s", view_function,
exc_info=True)
if self.debug:
# If the user has turned on debug mode,
# we'll let the original exception propogate so
# we'll let the original exception propagate so
# they get more information about what went wrong.
self.log.debug("Caught exception for %s", view_function,
exc_info=True)
stack_trace = ''.join(traceback.format_exc())
body = stack_trace
headers['Content-Type'] = 'text/plain'
Expand Down