Skip to content

feat(fake-tcp,phantun-client): add tcp keep-alive support to client - #236

Open
luhengsw wants to merge 1 commit into
dndx:mainfrom
luhengsw:keepalive-client
Open

feat(fake-tcp,phantun-client): add tcp keep-alive support to client#236
luhengsw wants to merge 1 commit into
dndx:mainfrom
luhengsw:keepalive-client

Conversation

@luhengsw

@luhengsw luhengsw commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

related to #93

@ccaapton

Copy link
Copy Markdown

@luhengsw Thanks a lot for your pull request. I'm building your version and works well. Would you mind implement another ACK feature as well?

In the current code, if one party has no payload to send, it will not send empty ACK to other party's payload unless there are more than 128Mb un-acked. But in linux conntrack, if some seq is not acknowledge within 300 seconds, the connection will be deemed dead, and linux conntrack will kill the connection. You can observe phantun behavior via iptstate, and see the established TCP connection has a lifetime of around 5min, because there are un-ACKed SEQ.

Can you also implement a delayed ack after a configurable timeout, even if the length is less than 128Mb? I think the reasonable timeout can be 5 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants