Open
Conversation
turn off masking based on sky spectra only
change default to no gaussian smoothing for xcorr raise specific exceptions rather than general add raw ccpeak to xcorr output and use it for selecting initial model add check for initial pars within bounds fix major bug in multifit_lsq jacobian change step sizes for derivatives add some memory cleanup add xcorr of final model with each spectrum and put in output modify to allow jointfit to run with single spectrum, for uniform interface trap for failed initial RVs in jointfit, and remove these, but proceed with others change weighting for initial paramters to be by S/N change vscatter to use std and not mad
put in keywords for maxvel add new continuum normalization to normalize obs and models the same way
mod for polynorm for 1D
fix velocity scale for xcorr
change fine grid range handling of single visit returns to make multi-visit handling of failed frames in single visit
add some exception trapping
fix velocity array for CCF add BC to CCF velocity array calculate full CCF, but just look for peak in input range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we can look through these together if you want
many are just adding some extra parameters, e.g. to input the range over which to search in the xcorr
one significant change is the normalization
another is to just use the peak pixel in the xcorr for the RV, since this is just a starting guess for the fit. The fitting of the xcorr peak seems to be challenging across a broad range of spectra. The code is all still there.
also do a final xcorr as a useful diagnostic and to use to input to the gaussian decomposition routine for multiple peaks