ci(release): use client-id input for create-github-app-token#60
Merged
Conversation
The action deprecated the app-id input in favor of client-id, which emitted a deprecation annotation on every release run. GitHub accepts the numeric App ID as the JWT issuer (client-id is just recommended over app-id), so the existing HOMEBREW_TAP_APP_ID secret value continues to work unchanged; only the input key needs renaming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow's
actions/create-github-app-tokenstep still used theapp-idinput, which the action has deprecated in favor ofclient-id. Every release run logged a deprecation annotation:This renames the input to
client-idwhile keeping the existingHOMEBREW_TAP_APP_IDsecret value. The action passes this value through as the JWTiss(issuer) claim, and GitHub's docs confirm both the numeric App ID and the Client ID are accepted as the issuer (Client ID is merely recommended). So no new secret is required and behavior is unchanged; only the deprecation warning goes away.📋 Deployment Pre/Post tasks
N/A
app-iddeprecation annotation no longer appears.