fix(runner): retain sent histograms for 24 hours

[linkdata]

Summary

• correct sent histogram cleanup retention from 12 hours to 24 hours
• centralize the expiry check in a named helper used by diskCleaner
• test both sides of the 24-hour threshold

Tests

• go test ./pkg/runner ./...

[coderabbitai]

Warning

Rate limit exceeded

@linkdata has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 55 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 31fce9f1-a573-4027-87bf-a667d6f2686e

📥 Commits

Reviewing files that changed from the base of the PR and between b615285 and c06a206.

📒 Files selected for processing (2)

• pkg/runner/runner.go
• pkg/runner/runner_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 55 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[linkdata]

Additional context from comment files

These notes were split from the local markdown comment files and attached here because they describe this PR's change.

Disk Cleaner Retention Period

• Bug: The diskCleaner used a variable named oneDay but set it to time.Hour * 12 (12 hours), not 24 hours. Sent histogram files were deleted after 12 hours instead of the intended 24 hours.
• Impact: Histogram files were retained for only half the intended duration, potentially causing data loss if the aggregate receiver was unavailable for more than 12 hours.
• Fix: Changed oneDay := time.Hour * 12 to oneDay := time.Hour * 24.
• Reasoning: The retention period should match the intended 24-hour window for aggregate data recovery.
• Tests: Added TestDiskCleanerRetentionThreshold to verify the retention threshold is correctly set to 24 hours.