Skip to content

fix(runner): unblock session send on cancellation#187

Open
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/session-send-cancel
Open

fix(runner): unblock session send on cancellation#187
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/session-send-cancel

Conversation

@linkdata
Copy link
Copy Markdown
Contributor

Summary

  • make runMinimiser session sends respect context cancellation
  • prevent shutdown from hanging when sessionCollectorCh is full
  • add a blocked-send cancellation regression test

Tests

  • go test ./pkg/runner ./...

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Warning

Rate limit exceeded

@linkdata has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 33 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2eb5827b-f7b1-4415-967d-378f821121c5

📥 Commits

Reviewing files that changed from the base of the PR and between b615285 and 04a2a16.

📒 Files selected for processing (2)
  • pkg/runner/run_minimiser_test.go
  • pkg/runner/runner.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 33 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@linkdata
Copy link
Copy Markdown
Contributor Author

Additional context from comment files

These notes were split from the local markdown comment files and attached here because they describe this PR's change.

Minimiser Session Send Backpressure

  • Bug: In runMinimiser(), the send to sessionCollectorCh at line 2121 was a plain blocking send. If the channel filled up (capacity 100), the minimiser goroutine would block inside the inputFrame processing case and could never reach the outer case <-edm.ctx.Done() to exit.
  • Impact: A slow or stalled dataCollector could prevent minimiser workers from shutting down gracefully, blocking minimiserWg.Wait() and stalling the entire shutdown sequence including the histogram flush.
  • Fix: Wrapped the channel send with a select that includes case <-edm.ctx.Done(), allowing the minimiser to exit when context is cancelled even if the channel is full.
  • Reasoning: All sends inside the main minimiser select must have a context escape hatch to honour graceful shutdown.
  • Tests: Added TestRunMinimiserSessionSendUnblocksOnContextCancel which fills sessionCollectorCh to capacity and verifies the minimiser exits promptly (within 2 seconds) when context is cancelled.

@linkdata linkdata marked this pull request as ready for review April 30, 2026 12:12
@linkdata linkdata requested a review from a team as a code owner April 30, 2026 12:12
@jschlyter jschlyter added the ai AI was used to write contributed code label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai AI was used to write contributed code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants