Skip to content

fix(runner): interrupt histogram sender backoff#188

Open
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/histogram-backoff-cancel
Open

fix(runner): interrupt histogram sender backoff#188
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/histogram-backoff-cancel

Conversation

@linkdata
Copy link
Copy Markdown
Contributor

Summary

  • make histogram sender retry backoff wake when the minimiser context is cancelled
  • avoid delaying shutdown during aggregate sender retry sleep

Tests

  • go test ./pkg/runner ./...

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Warning

Rate limit exceeded

@linkdata has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 31 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c4df18d3-210d-4525-85d9-077f01e9d0cf

📥 Commits

Reviewing files that changed from the base of the PR and between b615285 and e1bf495.

📒 Files selected for processing (1)
  • pkg/runner/runner.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 31 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@linkdata
Copy link
Copy Markdown
Contributor Author

Additional context from comment files

These notes were split from the local markdown comment files and attached here because they describe this PR's change.

Histogram Sender Backoff Interruptibility

  • Bug: In histogramSender(), when as.send() failed, the code called time.Sleep(backoffDuration) unconditionally (15 seconds). The sleep had no way to be interrupted by context cancellation, delaying shutdown by up to 15 seconds.
  • Impact: Graceful shutdown could be delayed by up to 15 seconds for each failed histogram send attempt, preventing timely process termination.
  • Fix: Replaced time.Sleep(backoffDuration) with a select that listens to both the timer and edm.ctx.Done(), allowing immediate exit on context cancellation.
  • Reasoning: Long-running operations inside goroutines must be interruptible by context cancellation for clean shutdown.
  • Tests: Verified by running the full test suite; no new test added as the fix is an internal optimization that doesn't change externally observable behavior (existing tests confirm the backoff still fires when intended).

@linkdata linkdata marked this pull request as ready for review April 30, 2026 12:12
@linkdata linkdata requested a review from a team as a code owner April 30, 2026 12:12
@jschlyter jschlyter added the ai AI was used to write contributed code label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai AI was used to write contributed code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants