Implement ExcelSheet::writeFormula() and ExcelSheet::setTabRgbColor()#30
Open
xperseguers wants to merge 5 commits intodoPhp:mainfrom
Open
Implement ExcelSheet::writeFormula() and ExcelSheet::setTabRgbColor()#30xperseguers wants to merge 5 commits intodoPhp:mainfrom
xperseguers wants to merge 5 commits intodoPhp:mainfrom
Conversation
This is mapped to following methods from LibXL: - xlSheetWriteFormulaNum() - precalculated double value - xlSheetWriteFormulaStr() - precalculated string value - xlSheetWriteFormulaBool() - precalculated bool value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExcelSheet::writeFormula()This enables creation of formula with arbitrary precalculated value to make preview and others show content instead of a "blank cell".
This effectively shall drop limitation in the README (https://github.com/doPhp/excel?tab=readme-ov-file#formulas-written-but-no-values-readable) that suggests to open file in Excel via COM and save back.
Implementation of the C methods:
xlSheetWriteFormulaNumxlSheetWriteFormulaStrxlSheetWriteFormulaBoolExcelSheet::setTabRgbColor()Similarly to the existing method
ExcelSheet::setTabColor(), this allows an arbitrary RGB color to be used for a sheet.Implementation of the C method:
xlSheetSetTabRgbColorMisc
ExcelSheet::readComment()andExcelSheet::writeComment()only work for .xls files (not .xlsx). This is stated in the LibXL documentation but wasn't specified explicitly in the PHP documentation