Coerce Ecto.Enum search values to their dumped representation#5
Open
Actalab wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Filtering on an
Ecto.Enumfield viaqcrashes at the adapter. A field like:filtered with
q[status_in][]=up(or through an association, e.g.q[category_status_in][]=published) buildsWHERE status = ANY($1)but passes the raw string["up"]. The column is an integer, so Postgrex raises:The search builder never applied the field's schema type, so enum values were sent uncast/undumped.
Fix
Attributenow carries the resolved schematype— but only when the value needs coercion (i.e.Ecto.Enum). Plain fields keeptype: niland pass through unchanged, so there is no behavior change for string/integer/uuid/etc. columns. The field is hidden fromInspect(@derive {Inspect, optional: [:type]}) so it doesn't leak into output.BuildSearchQuery.coerce_values/2casts then dumps each value through that type before the query is built ("up"→:up→1). If a value can't be cast to the enum it falls back to the raw value.Wherecoerces per attribute before delegating tohandle_expr.Works for every
Ecto.Enum(direct field or via association), including string-backed enums (dump returns the string).Tests
coerce_values/2(enum dump, untyped passthrough, invalid-value fallback).category_status_in) — this reproduces the reported crash and now returns the matching rows.35 doctests, 107 tests, 0 failures.