contrib/completion: bash nounset mode fixes#3965
Merged
Merged
Conversation
Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3965 +/- ##
=======================================
Coverage 59.20% 59.20%
=======================================
Files 287 287
Lines 24690 24690
=======================================
Hits 14617 14617
Misses 9189 9189
Partials 884 884 |
albers
approved these changes
Jan 26, 2023
albers
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed all instances I've come across that produce errors with the bash completion and the shell in
nounsetmode.- How I did it
Guarded variable accesses like
${something-}instead of directly accessing$somethingor${something}where the variable can be unset.- How to verify it
Set bash in
nounsetmode (set -uorset -o nounset), use the bash completion. Observe errors before this PR, no errors after.- Description for the changelog
A number of problems using the bash completion with the shell in
nounsetmode have been fixed.- A picture of a cute animal (not mandatory but encouraged)
:=}