test/e2e: Fix running test-e2e on non-amd64 platforms#4045
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4045 +/- ##
==========================================
- Coverage 59.16% 58.86% -0.30%
==========================================
Files 287 572 +285
Lines 24724 49572 +24848
==========================================
+ Hits 14627 29182 +14555
- Misses 9212 18624 +9412
- Partials 885 1766 +881 |
This comment was marked as spam.
This comment was marked as spam.
Collaborator
Author
|
Meh, test cases compare the output which contains a platform-specific manifest digest. |
vvoland
force-pushed
the
test-e2e-arm64-fixes
branch
from
a725eeb to
86a8c17
Compare
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
This makes it possible to update the image loaded for e2e tests without modifying all tests that use them. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
notary server version 0.5.0 is linux/amd64 only. Also, e2e stage from top level Dockerfile uses 0.6.1 notary version - change the Dockerfiles in e2e/testdata to have the same version. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Previous one was linux/amd64 only. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
test-e2e-arm64-fixes
branch
from
86a8c17 to
eeaaf5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
linux/amd64only)linux/amd64digests on non-linux/amd64platforms (and add TODOs)NOTE: This doesn't fix all failing tests (at least for me) on non amd64 platforms but at least makes the
test-e2estart and run tests (it didn't even launch the tests before).- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)