Skip to content

[20.10 backport] formatter: Consider empty RepoTags and RepoDigests as dangling#4066

Merged
thaJeztah merged 1 commit into
docker:20.10from
vvoland:dangling-images-none-2010
Mar 28, 2023
Merged

[20.10 backport] formatter: Consider empty RepoTags and RepoDigests as dangling#4066
thaJeztah merged 1 commit into
docker:20.10from
vvoland:dangling-images-none-2010

Conversation

@vvoland

@vvoland vvoland commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

Starting from API 1.43 version RepoTags and RepoDigests will be empty for dangling images, instead of being an one-item array with magic constant string (<none>:<none>/<none>@<none>).

CLI output is not impacted and will still display <none> strings.

(cherry picked from commit 89687d5)

- What I did
Consider images with empty RepoTags and RepoDigests as dangling.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 89687d5)
@vvoland vvoland added this to the 20.10.24 milestone Mar 2, 2023
@vvoland vvoland changed the title formatter: Consider empty RepoTags and RepoDigests as dangling [20.10 backport] formatter: Consider empty RepoTags and RepoDigests as dangling Mar 2, 2023

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 9560852 into docker:20.10 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants