docs: deprecation: OOM-score adjust for the daemon#4209
Merged
Conversation
The `oom-score-adjust` option was added to prevent the daemon from being OOM-killed before other processes. This option was mostly added as a convenience, as running the daemon as a systemd unit was not yet common. Having the daemon set its own limits is not best-practice, and something better handled by the process-manager starting the daemon. Docker v20.10 and newer no longer adjust the daemon's OOM score by default, instead setting the OOM-score to the systemd unit (OOMScoreAdjust) that's shipped with the packages. Users currently depending on this feature are recommended to adjust the daemon's OOM score using systemd or through other means, when starting the daemon. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_oom_score_adjust
branch
from
11c7999 to
c97c321
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4209 +/- ##
=======================================
Coverage 58.86% 58.86%
=======================================
Files 572 572
Lines 49544 49544
=======================================
Hits 29162 29162
Misses 18616 18616
Partials 1766 1766 |
dvdksn
reviewed
Apr 18, 2023
| ### OOM-score adjust for the daemon | ||
|
|
||
| **Deprecated in Release: v24.0.0** | ||
| **Target For Removal In Release: v25.0.0** |
Contributor
There was a problem hiding this comment.
Suggested change
| **Target For Removal In Release: v25.0.0** | |
| **Subject for Removal in Release: v25.0.0** |
Member
Author
There was a problem hiding this comment.
I'll keep this one to be the same, but we should indeed touch up this page a bit
Contributor
|
I just noticed that the formatting of these "Deprecated in Release" and "Removed in Release" phrases are a bit off. They use title case and bold, which isn't according to our style guide. And there's no blank line between these two lines, which renders them as one paragraph. I will raise a follow-up to this to improve the formatting of these. |
Member
Author
|
Yeah, it would use some tweaking; I used the existing approach, but definitely could use some touching up |
dvdksn
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
oom-score-adjustoption was added to prevent the daemon from being OOM-killed before other processes. This option was mostly added as a convenience, as running the daemon as a systemd unit was not yet common.Having the daemon set its own limits is not best-practice, and something better handled by the process-manager starting the daemon.
Docker 20.10 and newer no longer adjust the daemon's OOM score by default, instead setting the OOM-score to the systemd unit (OOMScoreAdjust) that's shipped with the packages.
Users currently depending on this feature are recommended to adjust the daemon's OOM score using systemd or through other means, when starting the daemon.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)