Skip to content

Swarm: Add schema 3.11, and Allow additional properties in build #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 2 commits into from
Apr 19, 2023
Merged

Swarm: Add schema 3.11, and Allow additional properties in build #4214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2bfd21
cli/compose: add schema 3.11 (no changes with 3.10 yet)
laurazard Apr 18, 2023
271b966
Swarm: allow additional properties in `build`
laurazard Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cli/compose/loader/loader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func strPtr(val string) *string {
}

var sampleConfig = types.Config{
Version: "3.10",
Version: "3.11",
Services: []types.ServiceConfig{
{
Name: "foo",
Expand Down Expand Up @@ -488,6 +488,17 @@ services:
assert.Check(t, is.ErrorContains(err, "services.foo.image must be a string"))
}

func TestIgnoreBuildProperties(t *testing.T) {
_, err := loadYAML(`
services:
foo:
image: busybox
build:
unsupported_prop: foo
`)
assert.NilError(t, err)
}

func TestLoadWithEnvironment(t *testing.T) {
config, err := loadYAMLWithEnv(`
version: "3"
Expand Down
Loading