Skip to content

dockerd(8): formatting fixes#4215

Merged
thaJeztah merged 2 commits into
docker:masterfrom
kolyshkin:fix-man
Apr 19, 2023
Merged

dockerd(8): formatting fixes#4215
thaJeztah merged 2 commits into
docker:masterfrom
kolyshkin:fix-man

Conversation

@kolyshkin

Copy link
Copy Markdown
Contributor

- What I did

Fixed some formatting in dockerd(8) man page.

- How I did it

vim man/dockerd.8.md
make manpages
man ./man/man8/dockerd.8
man -Tpdf ./man/man8/dockerd.8 > dockerd.pdf
# Proofread, compare to old version, repeat until satisfied.

- How to verify it

make manpages
man ./man/man8/dockerd.8
man -Tpdf ./man/man8/dockerd.8 > dockerd.pdf
# Proofread, compare to old version.

- Description for the changelog
n/a

- A picture of a cute animal (not mandatory but encouraged)

1. Escape asterisks and underscores, that have special meaning in
   Markdown. While most markdown processors are smart enough to
   distinguish whether it's a literal * or _ or a formatting directive,
   escaping makes things more explicit.

2. Fix using wrong level of headings in some dm options (most are ####,
   but some were #####).

3. Do not use sub-heading for examples in some dm options (this is how
   it's done in the rest of the man page).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Mostly, this makes sure that literals (such as true, false, host,
private, examples of options usage etc.) are typeset in bold, except for
filenames, which are typeset in italic.

While at it,
 - remove some default values from synopsis as it should not
   be there;
 - fix man pages references (page name in bold, volume number in
   regular).

This is not a complete fix, but a step in the right direction.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@codecov-commenter

codecov-commenter commented Apr 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4215 (8ef8f41) into master (67c4570) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4215   +/-   ##
=======================================
  Coverage   58.86%   58.86%           
=======================================
  Files         572      572           
  Lines       49544    49544           
=======================================
  Hits        29162    29162           
  Misses      18616    18616           
  Partials     1766     1766           

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@thaJeztah

Copy link
Copy Markdown
Member

@vvoland ptal

@thaJeztah thaJeztah merged commit d70b539 into docker:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants