Skip to content

[27.x backport] use important callout for buildkit vs legacy builder#5470

Merged
thaJeztah merged 1 commit into
docker:27.xfrom
dvdksn:cp_5469
Oct 4, 2024
Merged

[27.x backport] use important callout for buildkit vs legacy builder#5470
thaJeztah merged 1 commit into
docker:27.xfrom
dvdksn:cp_5469

Conversation

@dvdksn

@dvdksn dvdksn commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
(cherry picked from commit 8a3d838)
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested review from a team and thaJeztah as code owners September 23, 2024 11:41
@codecov-commenter

codecov-commenter commented Sep 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.78%. Comparing base (ce12230) to head (23cea90).
Report is 10 commits behind head on 27.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             27.x    #5470      +/-   ##
==========================================
+ Coverage   59.39%   59.78%   +0.39%     
==========================================
  Files         342      345       +3     
  Lines       23434    23442       +8     
==========================================
+ Hits        13918    14015      +97     
+ Misses       8540     8453      -87     
+ Partials      976      974       -2     

@dvdksn dvdksn self-assigned this Sep 23, 2024
@thaJeztah thaJeztah added this to the 27.4.0 milestone Oct 4, 2024

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit fa0bb9f into docker:27.x Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants