Skip to content

DKP-2859 start: bound docker readiness wait and dump logs on timeout #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebriney merged 2 commits into from
Jun 9, 2026
+26 −1
Merged

DKP-2859 start: bound docker readiness wait and dump logs on timeout #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebb7342
start: bound docker readiness wait and dump logs on timeout
mat007 Jun 9, 2026
6116eeb
docs: recommend a 4 vCPU / 16 GB runner
mat007 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,19 @@ Note that the usage of Docker Desktop is subject to [Docker Desktop license agre

After this step executes, Docker Desktop is ready and available, the docker CLI can be executed in subsequent "run" steps

## Choosing a runner

Docker Desktop runs a Linux VM, so the runner needs enough CPU and memory or
`dockerd` can fail to finish starting and the action hangs waiting on the daemon.
At least 4 vCPUs and 16 GB of RAM is a good baseline.

Watch out for `ubuntu-latest`: GitHub gives public repositories a 4 vCPU / 16 GB
runner, but private and internal repositories get a smaller 2 vCPU / 7 GB one,
and on that box `dockerd` often stalls during startup and never becomes ready.
If your repository is private or internal, pick a larger runner (e.g. a
[GitHub larger runner](https://docs.github.com/en/actions/using-github-hosted-runners/about-larger-runners)
with 4 vCPUs / 16 GB), not plain `ubuntu-latest`.

By default, the action downloads the last version of Docker Desktop. But you can specify another one by providing the build URL from where the action can download the specific version:

```
Expand Down
14 changes: 13 additions & 1 deletion start/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,18 @@ runs:
- name: Wait for Docker to be up and running
shell: bash
run: |
until docker ps; do echo "docker not ready, sleep 10 s and try again"; sleep 10; done
deadline=$(( $(date +%s) + 600 ))
until timeout 60 docker ps >/dev/null 2>&1; do
if (( $(date +%s) >= deadline )); then
echo "::error::Docker did not become ready within 600s"
echo "----- host logs (incl. backend) -----"
cat ~/.docker/desktop/log/host/*.log 2>/dev/null || true
echo "----- vm logs (console) -----"
cat ~/.docker/desktop/log/vm/*.log 2>/dev/null || true
exit 1
fi
echo "docker not ready, sleep 10 s and try again"

@martin-podlubny martin-podlubny Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

within 600s vs. sleep 10 s. I prefer without space. Either way, better stay consistent with the two occurrences.

@mat007 mat007 Jun 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I’ll open a follow-up.

@mat007 mat007 Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Opened #38 to make the spacing consistent in a follow-up.

sleep 10
done
echo "Docker started and ready"
docker version
Loading