Fix table text copy not matching selection#2175
Merged
dgageot merged 3 commits intodocker:mainfrom Mar 19, 2026
Merged
Conversation
When selecting text in tables, the copied content did not match the visual selection because border characters (│, ─, etc.) were not properly accounted for when mapping visual column positions to text content. The fix maps visual column positions from the rendered line (with borders) to the stripped line (without borders) by tracking which runes correspond to which visual columns, ensuring the copied text matches what the user selected. Fixes: docker#2167 Signed-off-by: Md Yunus <admin@yunuscollege.eu.org>
0dd1255 to
89fbd72
Compare
dgageot
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #2167 where text copied from tables did not match the visual selection.
Root Cause
When selecting text in tables, the copied content did not match the visual selection because border characters (│, ─, etc.) were not properly accounted for when mapping visual column positions to text content.
The previous implementation used a simple offset calculation that subtracted the total border width from column positions, but this didn't account for the actual positions of border characters within the line.
Changes
pkg/tui/components/messages/clipboard.go
visualToRunemapping to track which runes correspond to which visual columnsfindClosestRuneIndex()helper function to map visual column positions to rune indicesextractSelectedText()to properly map visual selection positions to text contentHow It Works
Testing
Related Issue
Fixes #2167