Merged
Conversation
Assisted-By: docker-agent
Assisted-By: docker-agent
Assisted-By: docker-agent
…nline helpers Assisted-By: docker-agent
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR simplifies the modelsdev package by removing unused fields and streamlining the code structure. The refactoring is clean and maintains the same functionality.
Changes reviewed:
- ✅ Removed unused fields from
ProviderandModelstructs - ✅ Removed unused
CachedAtandUpdatedAttimestamps - ✅ Converted
NewStoreto usesync.OnceValuesdirectly (cleaner singleton pattern) - ✅ Changed
GetProvidertogetProvider(unexported, internal use only) - ✅ Removed unused
ModelSupportsReasoningfunction - ✅ Simplified Bedrock region prefix handling (inlined helper function)
- ✅ Updated test fixtures to match simplified structs
Concurrency safety: The mutex usage in GetDatabase and getProvider is correct. The cached database is immutable after loading, making concurrent reads safe.
No bugs found in the changed code. The simplification improves code maintainability without introducing issues.
rumpl
approved these changes
Mar 19, 2026
Member
rumpl
left a comment
There was a problem hiding this comment.
Can we stop simplifying? It's going in circles at this point
Member
|
Do we really have to remove the fields? It's a public package and external might need it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.