-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update Develop with containers (and) CONTRIBUTING.MD #23987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| ``` | ||
|
|
||
| 3. If you haven't done so yet, save the file. If you refresh your browser, you should see a new greeting. If you keep refreshing, you should see all of the messages appear. | ||
| 3. Save the file if you haven't done so yet, then run the following command again: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With docker compose watch the idea is that you don't have to re-enter the command as it's purpose is to automatically update and preview your running Compose services as you edit and save your code. So this shouldn't be necessary.
SO! It looks like you've found a bug. I'll take this to the Compose team to figure out what's going on.
| $ docker buildx bake validate | ||
| ``` | ||
| ```console | ||
| $ docker buildx bake validate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it still copies the '$', but it does that for all the commands on that page 🤔
Probs a github issue rather than us
This is a two part PR for some simple edits. I found them while working through docs site ~foundations, and I have a task to file my first PR anyway. 😸
Includes:
### Change the greetingsection. Live step omits that you need to re-rundocker compose watchin addition to saving the file after you've updated the variable. I saw that this was also flagged in our feedback channel, too.$, which the others do not do. The only difference I saw that might create that buggy behavior is the indent. 🖖