Compose: lifecycle hook update#25435
Conversation
Signed-off-by: aevesdocker <allie.sadler@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
area/compose
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
This PR adds documentation for the new pre_start lifecycle hook. Three issues need attention before merging: one unresolved internal placeholder that would ship to users, and two factual inconsistencies between the how-to guide and the reference page.
|
|
||
| ### pre_start | ||
|
|
||
| _Todo: Add Compose version_ |
There was a problem hiding this comment.
[HIGH] Unresolved TODO placeholder left in published reference documentation
The new pre_start section contains _Todo: Add Compose version_ as its second line. This internal reminder will be rendered as italic text on the published docs site and is visible to all users. The minimum Compose version that supports pre_start should be determined and documented before merging.
Signed-off-by: aevesdocker <allie.sadler@docker.com>
3 participants
Description
As per docker/compose#13862 and compose-spec/compose-spec#647
Related issues or tickets
Reviews