Conversation
Signed-off-by: Johannes Großmann <grossmann.johannes@t-online.de>
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This is a straightforward dependency bump of the internal github.com/docker/secrets-engine/x module from v0.0.32-do.not.use to v0.0.33-do.not.use.
Verified:
- All consuming modules (
client,plugin,plugins/credentialhelper,plugins/pass,store) are consistently updated tov0.0.33-do.not.use— no module left behind on the old version. vendor/modules.txtreflects the new version correctly.go.work.sumgains the expected new hash entries (docker-credential-helpers v0.9.4) and drops obsolete indirect hashes — consistent with the dependency bump.- No mismatched
require/replacedirectives found.
No bugs or version inconsistencies introduced by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.